Needs some code critique...

Post Reply
relminator
Posts: 84
Joined: Sun Apr 11, 2010 10:43 am

Needs some code critique...

Post by relminator » Mon Sep 20, 2010 5:00 am

Hi guys, I started writing the codes for my little DS tutorial. I want to ask for some criticisms with my example codes. Being a non-C coder, I may have messed some things up.

http://rel.betterwebber.com/junk.php?id=112

I need your advices before I write the actual article.

Thanks!

PS. I'll also add some platforming engine and a parallax scrolling demo.

WinterMute
Site Admin
Posts: 2003
Joined: Tue Aug 09, 2005 3:21 am
Location: UK
Contact:

Re: Needs some code critique...

Post by WinterMute » Tue Sep 21, 2010 8:55 pm

Finally got a chance to look at this today, looking pretty good.

First thing, always clean projects before packing them up for distribution - the devkitPro templates autogenerate dependencies which use absolute paths and anyone trying to build your code will need to clean them first.

Some of the functions you have in there I think should probably be assimilated into libnds - glVertex3i, glVertex2i & glTexcoord2i for instance. Does your ortho code actually do pixel co-ordinates? That's something I've been meaning to look at with our examples.

For the general 2D code - tiles, sprites etc I think it would probably be best to look at making that into a library for inclusion along with the rest of the devkitPro libraries if you're willing?
Help keep devkitPro toolchains free, Donate today

Personal Blog

relminator
Posts: 84
Joined: Sun Apr 11, 2010 10:43 am

Re: Needs some code critique...

Post by relminator » Mon Sep 27, 2010 7:19 am

Sorry for the late reply, I was hospitalized for a few days.

Thanks for the clean tip. It's a wonder it didn't occur to me a all. LOL
Some of the functions you have in there I think should probably be assimilated into libnds - glVertex3i, glVertex2i & glTexcoord2i for instance. Does your ortho code actually do pixel co-ordinates? That's something I've been meaning to look at with our examples.

For the general 2D code - tiles, sprites etc I think it would probably be best to look at making that into a library for inclusion along with the rest of the devkitPro libraries if you're willing?
Yep, the coordinates they need as arguments have a 1:1 correspondence to screen coordinates.

I'd be happy to see them included in devkitPro. ;*)

Thanks for the comments.

relminator
Posts: 84
Joined: Sun Apr 11, 2010 10:43 am

Re: Needs some code critique...

Post by relminator » Thu Sep 30, 2010 2:45 am

Yo WinterMute,

I'm in the process of writing my article. Can you confirm the functions that would be included on the next libnds release? I don't want any name conflicts from libnds.

Or I could just wait for the next release of libnds before I recode my article. What do you suggest?

Post Reply

Who is online

Users browsing this forum: Bing [Bot] and 0 guests