Page 1 of 1

[PATCH] Correct return value of net_init()

Posted: Sat Mar 14, 2009 2:39 pm
by SimonKagstrom
This patch fixes net_init in non-error cases. I guess an error sneaked in sometime here :-)

// Simon

Code: Select all

Index: libogc/network_wii.c
===================================================================
RCS file: /cvsroot/devkitpro/libogc/libogc/network_wii.c,v
retrieving revision 1.19
diff -u -r1.19 network_wii.c
--- libogc/network_wii.c	9 Dec 2008 11:30:06 -0000	1.19
+++ libogc/network_wii.c	14 Mar 2009 13:38:38 -0000
@@ -321,6 +321,7 @@
 
 	debug_printf(" %d.%d.%d.%d\n", octets[0], octets[1], octets[2], octets[3]);
 
+        return ret;
 error:
 	IOS_Close(net_ip_top_fd);
 	net_ip_top_fd = -1;

Re: [PATCH] Correct return value of net_init()

Posted: Mon Mar 16, 2009 2:37 am
by WinterMute
Um, the return code on success happens to be 0. Also, we moved from CVS to SVN in December.

Re: [PATCH] Correct return value of net_init()

Posted: Mon Mar 16, 2009 6:17 pm
by SimonKagstrom
OK, great. I see that it's fixed in the svn trunk so please ignore the message.

I also see that poll was implemented, which is something I missed before (or select), so that's very good.

// Simon