libnds: REG_BG2X_SUB_H naming inconsistency
Posted: Sat May 03, 2008 7:19 pm
nds\arm9\background.h > lines 378 to 383.
should be changed to:
For consistency with all the rest of definitions.
And the doxygen comments at lines 394 & 398, should indicate "(sub engine)" instead of "(main engine)":
Code: Select all
#define REG_BG2X_SUB_L (*(vu16*)0x4001028)
#define REG_BG2X_SUB_H (*(vu16*)0x400102A)
/*! \brief Background 2 Screen Offset (sub engine)*/
#define REG_BG2Y_SUB (*(vu32*)0x400102C)
#define REG_BG2Y_SUB_L (*(vu16*)0x400102C)
#define REG_BG2Y_SUB_H (*(vu16*)0x400102E)
Code: Select all
#define REG_BG2X_L_SUB (*(vu16*)0x4001028)
#define REG_BG2X_H_SUB (*(vu16*)0x400102A)
/*! \brief Background 2 Screen Offset (sub engine)*/
#define REG_BG2Y_SUB (*(vu32*)0x400102C)
#define REG_BG2Y_L_SUB (*(vu16*)0x400102C)
#define REG_BG2Y_H_SUB (*(vu16*)0x400102E)
And the doxygen comments at lines 394 & 398, should indicate "(sub engine)" instead of "(main engine)":
Code: Select all
/*! \brief Background 3 Screen Offset (main engine)*/
#define REG_BG3X_SUB (*(vu32*)0x4001038)
#define REG_BG3X_L_SUB (*(vu16*)0x4001038)
#define REG_BG3X_H_SUB (*(vu16*)0x400103A)
/*! \brief Background 3 Screen Offset (main engine)*/
#define REG_BG3Y_SUB (*(vu32*)0x400103C)
#define REG_BG3Y_L_SUB (*(vu16*)0x400103C)
#define REG_BG3Y_H_SUB (*(vu16*)0x400103E)