Some minor typos in predefined GXRModeObj
Posted: Tue May 27, 2008 10:56 am
I just found these while debugging an application:
in TVPal264Ds & TVPal264DsAa:
the following has no impact since YOrigin is 0 in every case but:
in TVNtsc240Ds & TVNtsc240DsAa:
btw, EURGB60_ modes are missing from video_types.h
in TVPal264Ds & TVPal264DsAa:
should be(VI_MAX_HEIGHT_PAL/2 - 528/2)/2, // viYOrigin
in TVEurgb60Hz240Ds & TVEurgb60Hz240DsAa(VI_MAX_HEIGHT_PAL - 528)/2, // viYOrigin
should be(VI_MAX_HEIGHT_EURGB60 - 480/2)/2, // viYOrigin
(VI_MAX_HEIGHT_EURGB60 - 480)/2, // viYOrigin
the following has no impact since YOrigin is 0 in every case but:
in TVNtsc240Ds & TVNtsc240DsAa:
should be(VI_MAX_HEIGHT_NTSC/2 - 480/2)/2, // viYOrigin
generally, viYOrigin should always be (VI_MAX_HEIGHT-viHeight)/2, even when using non-interlaced doublestrike modes, only XFB height is divided by two, not VI(VI_MAX_HEIGHT_NTSC - 480)/2, // viYOrigin
btw, EURGB60_ modes are missing from video_types.h